Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync watchers break subsequent updates #12045

Closed
skirtles-code opened this issue Sep 26, 2024 · 0 comments
Closed

Sync watchers break subsequent updates #12045

skirtles-code opened this issue Sep 26, 2024 · 0 comments
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. regression scope: reactivity

Comments

@skirtles-code
Copy link
Contributor

skirtles-code commented Sep 26, 2024

Vue version

3.5.9

Link to minimal reproduction

https://play.vuejs.org/#eNqFUklP6zAQ/isjX1pElD7gvcOr0opFHOAAiOWEEQpm2gYc2/JSiqL8d8axAkFiudnfMvPN2A07MCZfB2RTVjhhK+PBoQ9mzlVVG209NGBxkcFL6cUKWlhYXcOIHCOuuBJaOQ9CB+V3YBaV4z9bn+DdAcxVV2Wc9BmMt2A2h4YrIK1yWmIu9XI8cq9KjEgf4VgiX5cy4PY2V21GeRYyuBVMkwzaQeHbvnLy3X3fwliEndhjaP8tVzTt9qZikvZFm6KLx9rI0iPdAJqmX0nbQvEQvNcK9oWsxPOMs0TRNGx+Y4pJoslXTAZFWMa8o+aLapk/Oa3ofbo80V6bSqI9N76icJxNU9LIlVLql9MO8zZg1uNiheL5C/zJbSLG2YVFh3aNnL1zvrRL9Ik+vjrDDZ3fyVo/BknqH8hLpMWFmDHJDoN6pNgDXZf2pPtllVpeu+ONR+X6oWLQqGw7PWf05Y5+GP0j7l7+t/PRM9EW79doY01a4F7+L//P2jcwdvkP

Steps to reproduce

Just click the button.

What is expected?

All the watchers should log and rendering should update.

What is actually happening?

The first two watchers log, but everything after that stops reacting.

System Info

No response

Any additional comments?

I believe this is caused by 10ff159. The reproduction works correctly in 3.5.8.

The NOTIFIED flags all get cleared up front in endBatch(). The sync watcher notifies subscribers that are already in the running batch, leading to the next flag being incorrectly reset. The subscribers linked via the original next value are never run.

@edison1105 edison1105 added scope: reactivity ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. regression labels Sep 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. regression scope: reactivity
Projects
None yet
Development

No branches or pull requests

2 participants