Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(renderList): warn with v-for has non-integer range number #2247

Merged
merged 9 commits into from
Oct 13, 2020
Merged

feat(renderList): warn with v-for has non-integer range number #2247

merged 9 commits into from
Oct 13, 2020

Conversation

underfin
Copy link
Member

close #2245

@RobbinBaauw
Copy link
Contributor

Isn't an explicit error better? This is only going to cause more confusion as you may suddenly render more than expected.

@underfin underfin changed the title feat(renderList): v-for render non-integer range number feat(renderList): warn with v-for has non-integer range number Sep 27, 2020
@underfin
Copy link
Member Author

Thanks for all review :)

@yyx990803 yyx990803 merged commit 02f355e into vuejs:master Oct 13, 2020
@underfin underfin deleted the non-integer-value-range-v-for branch October 14, 2020 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacekkarczmarczyk jacekkarczmarczyk jacekkarczmarczyk left review comments

@RobbinBaauw RobbinBaauw RobbinBaauw left review comments

@dsonet dsonet dsonet requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Unhandled error during execution of render function" while using v-for with a non-interger value
5 participants
@underfin @RobbinBaauw @dsonet @jacekkarczmarczyk @yyx990803