-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onServerPrefetch #3070
feat: onServerPrefetch #3070
Conversation
Size report
|
Would we technically consider this a new feature, requiring a minor release? We're putting together 3.0.6, if we include this, we'd have to go to 3.1 instead. Just mentioning as we had other features, not coming right now, labelled for 3.1. so we would have to relabel them for 3.2 |
The GH action can't download the |
Oh, sorry, I took a closer look at that PR(#2902), the conclusion is that these two cannot coexist because they basically do the same thing. The #2902 also provides an implementation of |
@LinusBorg @posva , Can you help me take a look at these two PRs(#2902 and #3070)? thanks. |
.then(() => | ||
Promise.all(prefetches.map(prefetch => prefetch.call(instance.proxy))) | ||
) | ||
.catch(() => {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: error display is already done by the wrapped lifecycle hook function.
Sorry I've been a bit busy recently.
That sounds like a lot of work. Alternatively, maybe you can add me as a co-author when merging this request? In which case please use I'll close #2902 once this is merged. |
How is this feature related to "Suspense + Async Setup"? |
I still have this issue with vite. A patch that I found in the issue fixed it but only for dev. After build it's coming back. Any updates on how it can be fixed on build time? |
Most notably this is lacking ssr support with vue3 pending vuejs/core#3070 see #148 for latest progress & status
7edfc56
to
7a93cd5
Compare
Add a Composition API lifecycle hook
onServerPrefetch
that merge the passed handler function to theserverPrefetch
component option.Related to vuejs/apollo#1102