Ensure value for OPTION elements is properly set in edge case (fix #4956) #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusBorg
changed the title
even when they have a matching textContent close #4956
LinusBorg
force-pushed
the
linusborg/fix-option-value-4956
branch
from
80dc49b
to
55e8c54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers an edge case where the OPTION element has a
textContentmatching its assignedvalueattribute.Previously, Vue would fail to properly assign the value in this case (and consequently, the
valueattribute was missing), because for OPTION elements,el.valuefalls back toel.textContentwhen no distinct value has been set (yet)close #4956