Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): SVGAttributes style hint type error #6322

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

JayMeDotDot
Copy link
Contributor

Normally, when we binding :style to an array of multiple objects in common HTML elements, ts wouldn't hint a type error. But if we do this in SVG elements, ts would hint a type error.

when we binding :style in common HTML elements:

截屏2022-07-21 00 26 05

when we binding :style in SVG elements:

截屏2022-07-20 23 20 17

SVGAttributes.style type may be StyleValue, since vue compiler can parse this correctly.

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Jun 12, 2023
@yyx990803 yyx990803 merged commit 364dc53 into vuejs:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants