perf(reactivity): better computed tracking #710
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made
computed
usetrack
andtrigger
directly.Why?
trackChildRun
depended onactiveEffect
and was basically a copy of tracking internals. The new code is straightforward to understand: it simply callstrack
when value is read.N
dependencies andM
readers, before PR we hadN*(M+1)
entries, after PRN+M
.Not only does it save space, it also saves time if many dependencies change at once. If
N
dependencies change at once, the number function calls is the same as the entries above (after PR,computed
only callstrigger
once, rather than having a notification for every dependency that changes).