fix(hmr): fix the page not updating when using computed value as slot… #7158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangzhonghe
added
the
🍰 p2-nice-to-have
|
Hi, |
zhangzhonghe
force-pushed
the
fix-7155
branch
from
bf64137
to
bc3615f
Compare
haoqunjiang
added
🔨 p3-minor-bug
I am also waiting on this fix. Super annoying that HMR does not work. @zhangzhonghe Is there any way I can use this fix today somehow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#7155)
fix #7155
I found that there are component libraries (e.g. here) that render component slots by computed wrapping and then rendering them dynamically in the template. This can lead to a situation where HMR does not cause the page to update when the user changes the template content.