fix(compiler-core): proper scope analysis for ssr vnode slot fallback #7184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edison1105
changed the title
|
Can this be merged? |
|
Merge please |
|
Could anyone merge this, please? |
|
I don't want to be annoying but this PR has been ready to merge for half a year now, and it fixes serious hydration errors. Can this be merged so I can finally get rid of those errors? |
I'm also blocked by this. |
pdanpdan
reviewed
Jun 22, 2023
|
why no merge? 🥲 |
Size ReportBundles
Usages
|
chore: improve code chore: improve code chore: improve code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #7095
the root cause see #7095 (comment)