Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): check used import bindings for template ref #7593

Merged
merged 4 commits into from
Jul 11, 2023
Merged

fix(compiler-sfc): check used import bindings for template ref #7593

merged 4 commits into from
Jul 11, 2023

Conversation

vaakian
Copy link
Contributor

@vaakian vaakian commented Jan 28, 2023

fixes #7567

@vaakian vaakian changed the title fix(compiler-sfc): used import bindings check for template ref fix(compiler-sfc): check used import bindings for template ref Jan 28, 2023
@netlify
Copy link

netlify bot commented Jan 28, 2023 •
edited
Loading

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 28be673
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/63d8f6cc657c9900099eedd8

@sxzz sxzz force-pushed the fix/compiler-sfc branch from 5fa3507 to 82a9d79 Compare February 1, 2023 15:11
@vaakian vaakian force-pushed the fix/compiler-sfc branch 2 times, most recently from e894150 to 2ece989 Compare February 4, 2023 10:00
@sxzz sxzz force-pushed the fix/compiler-sfc branch from 2ece989 to 118ae5b Compare February 4, 2023 17:40
@ferferga
Copy link
Contributor

@sxzz I'm so sorry for directly pinging you, but I'd like to know if there's something we can do to have this merged since it's a deal breaker for our workflow and it looks like a trivial fix.

Thank you very much in advance! ❤️

@sxzz sxzz force-pushed the fix/compiler-sfc branch from 118ae5b to 623361d Compare June 10, 2023 10:09
sxzz and others added 2 commits June 10, 2023 18:10
@sxzz sxzz added the ready to merge The PR is ready to be merged. label Jun 10, 2023
@sxzz
Copy link
Member

sxzz commented Jun 10, 2023

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Jun 10, 2023 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
nuxt ✅ success
pinia ✅ success
quasar ❌ failure
router ❌ failure
test-utils ❌ failure
vant ✅ success
vite-plugin-vue ✅ success
vitepress ❌ failure
vue-macros ❌ failure
vuetify ✅ success
vueuse ✅ success
vue-simple-compiler ✅ success

@sxzz @edison1105
Update packages/compiler-sfc/__tests__/compileScript.spec.ts
e4156d4 
Co-authored-by: edison <daiwei521@126.com>
@yyx990803 yyx990803 merged commit 776ebf2 into vuejs:main Jul 11, 2023
@vaakian vaakian deleted the fix/compiler-sfc branch July 15, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 requested changes

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TypeScript] Imported refs can't be used as template refs in development
6 participants
@vaakian @ferferga @sxzz @vue-bot @edison1105 @yyx990803