Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): support nested namespaces in global types #8102

Closed
wants to merge 1 commit into from
Closed

fix(compiler-sfc): support nested namespaces in global types #8102

wants to merge 1 commit into from

Conversation

innocenzi
Copy link

@innocenzi innocenzi commented Apr 17, 2023

This draft PR is an attempt at supporting references in the global types support recently added by Evan in 4e028b9.

For now the PR only contains a failing test that demonstrates the issue. cc @yyx990803 if you know how to support this — I'm still currently figuring out the source code to try and fix this myself in the meantime.

Related: #8083

EDIT: after a bit more of debugging, it seems the issue is nested namespaces actually. eg. App.AircraftData is recognized but not App.Data.AircraftData.

@innocenzi innocenzi marked this pull request as draft April 17, 2023 12:32
@innocenzi innocenzi changed the title fix(compiler-sfc): support references in global types fix(compiler-sfc): support nested namespaces in global types Apr 17, 2023
@yyx990803 yyx990803 closed this in d53e157 Apr 20, 2023
IAmSSH pushed a commit to IAmSSH/core that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant