fix(runtime-core): swap client/server debug labels #9089

danielroe · 2023-08-30T21:25:35Z

At the moment I think the console log is misleading.

The text here labelled 'Client' is in fact the server rendered HTML. I think reversing these two labels might be better.

github-actions · 2023-08-30T21:26:49Z

Size Report

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	85.8 kB	32.6 kB	29.5 kB
vue.global.prod.js	132 kB	49.3 kB	44.3 kB

Name	Size	Gzip	Brotli
createApp	47.9 kB	18.8 kB	17.2 kB
createSSRApp	50.6 kB	19.9 kB	18.2 kB
defineCustomElement	50.3 kB	19.6 kB	17.9 kB
overall	61.2 kB	23.7 kB	21.6 kB

danielroe added 2 commits August 30, 2023 22:24

fix(runtime-core): swap client/server debug labels

9fbe32d

fix: reverse other condition as well

474b9af

edison1105 approved these changes Aug 31, 2023

View reviewed changes

baiwusanyu-c approved these changes Aug 31, 2023

View reviewed changes

sxzz approved these changes Aug 31, 2023

View reviewed changes

sxzz added the ready for review This PR requires more reviews label Aug 31, 2023

sxzz requested a review from haoqunjiang August 31, 2023 07:06

sxzz added the scope: ssr label Aug 31, 2023

danielroe mentioned this pull request Aug 31, 2023

Confusing message about a Hydration text content mismatch nuxt/nuxt#22931

Closed

haoqunjiang approved these changes Aug 31, 2023

View reviewed changes

haoqunjiang added ready to merge The PR is ready to be merged. and removed ready for review This PR requires more reviews labels Aug 31, 2023

sxzz added the need discussion label Sep 5, 2023

Update hydration.ts

b8bf470

yyx990803 merged commit 8f311c6 into vuejs:main Sep 5, 2023
8 of 9 checks passed