Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime-dom): add xmlns:xlink to SVGAttributes #9300

Merged
merged 9 commits into from
Dec 8, 2023
Merged

feat(runtime-dom): add xmlns:xlink to SVGAttributes #9300

merged 9 commits into from
Dec 8, 2023

Conversation

Alfred-Skyblue
Copy link
Member

close #9299

@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.5 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 48 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.4 kB 19.7 kB 17.9 kB
overall 61.4 kB 23.7 kB 21.6 kB

@zm-john
Copy link

zm-john commented Sep 27, 2023 via email

@Alfred-Skyblue Alfred-Skyblue changed the title types(runtime-dom): add xmlns:xlink to SVGAttributes feat(runtime-dom): add xmlns:xlink to SVGAttributes Sep 27, 2023
@pikax pikax added scope: types 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Oct 13, 2023
@pikax pikax added the ready to merge The PR is ready to be merged. label Oct 13, 2023
@yyx990803 yyx990803 merged commit 0d61b42 into vuejs:main Dec 8, 2023
11 checks passed
@Alfred-Skyblue Alfred-Skyblue deleted the fix/svg-type branch December 8, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikax pikax pikax approved these changes

@sxzz sxzz sxzz approved these changes

@baiwusanyu-c baiwusanyu-c baiwusanyu-c approved these changes

Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: types
Projects
Issue / PR Management
Status: Merged
Next Minor
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roperty 'xmlns:xlink' does not exist on type 'SVGAttributes & ReservedProps'
6 participants
@Alfred-Skyblue @zm-john @pikax @sxzz @baiwusanyu-c @yyx990803