Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(ComponentPublicInstance): fix generated props to keep ComponentCustomProps #9468

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

pikax
Copy link
Member

@pikax pikax commented Oct 24, 2023

closes #8376

Prettify when used on a type (eg: ComponentCustomProps), it will erase the type to make a new type, which when is known types is not desired, so we only apply to the Props instead.

@pikax pikax added scope: types ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Oct 24, 2023
@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.5 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.9 kB 17.3 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@netlify

This comment was marked as off-topic.

@netlify

This comment was marked as off-topic.

@yyx990803 yyx990803 merged commit 7374e93 into main Oct 24, 2023
13 checks passed
@yyx990803 yyx990803 deleted the pikax/types_fix_generated_props_defineComponent branch October 24, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: types
Projects
Development

Successfully merging this pull request may close these issues.

ComponentCustomProps is erased in distributed component types
2 participants