Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-core): fix conflicts between template variables and global variables #9492

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

Alfred-Skyblue
Copy link
Member

@Alfred-Skyblue Alfred-Skyblue commented Oct 27, 2023

fixed #9482

When there is a naming conflict between variables in bindingMetadata and global variables, prioritize the variables in bindingMetadata.

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit a1e4395
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/653b68c7ed734d00086ab039

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.5 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@Alfred-Skyblue Alfred-Skyblue marked this pull request as ready for review October 27, 2023 07:30
@Alfred-Skyblue Alfred-Skyblue changed the title fix: use Metadata first fix: fix variable naming conflicts using priority Oct 27, 2023
@Alfred-Skyblue Alfred-Skyblue changed the title fix: fix variable naming conflicts using priority fix(compiler-core): fix variable naming conflicts using priority Oct 27, 2023
@Alfred-Skyblue Alfred-Skyblue force-pushed the fix/template-var branch 2 times, most recently from 5add3e0 to 29d4fc6 Compare October 27, 2023 08:28
@Alfred-Skyblue Alfred-Skyblue changed the title fix(compiler-core): fix variable naming conflicts using priority fix(compiler-core): fix conflicts between template variables and global variables Oct 27, 2023
@yyx990803 yyx990803 merged commit a75d1c5 into vuejs:main Oct 28, 2023
11 checks passed
@Alfred-Skyblue Alfred-Skyblue deleted the fix/template-var branch October 30, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicts between variable in templates and built-in function name
2 participants