Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(runtime-core): export MultiWatchSources type #9563

Merged
merged 9 commits into from
Aug 2, 2024
Merged

chore(runtime-core): export MultiWatchSources type #9563

merged 9 commits into from
Aug 2, 2024

Conversation

DamianGlowala
Copy link
Contributor

@DamianGlowala DamianGlowala commented Nov 7, 2023 •
edited
Loading

This PR will make it possible to keep types in sync and remove duplication on the Nuxt's side:
https://github.com/nuxt/nuxt/blob/2832f0114b3365c8e7aadbf05b444443db64f818/packages/nuxt/src/app/composables/asyncData.ts#L35

@netlify Netlify
Copy link

netlify bot commented Nov 20, 2023

❌ Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit 1092cd2
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/655bdb8d984ff80008257eb6

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.4 kB 34 kB 30.7 kB
vue.global.prod.js 146 kB 53.3 kB 47.6 kB

Usages

Name Size Gzip Brotli
createApp 49.7 kB 19.5 kB 17.8 kB
createSSRApp 53.1 kB 20.8 kB 19 kB
defineCustomElement 52 kB 20.2 kB 18.5 kB
overall 63.2 kB 24.4 kB 22.2 kB

@pikax pikax added scope: types 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Nov 22, 2023
@haoqunjiang haoqunjiang added ready to merge The PR is ready to be merged. version: minor labels Jun 16, 2024
@yyx990803 yyx990803 changed the base branch from main to minor August 2, 2024 04:42
@yyx990803 yyx990803 merged commit 998dca5 into vuejs:minor Aug 2, 2024
5 checks passed
@DamianGlowala DamianGlowala mentioned this pull request Aug 14, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: types version: minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DamianGlowala @haoqunjiang @yyx990803 @pikax