fix(useCssVars): fix the loss of CSS variables during updates #9824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
CodSpeed Performance ReportMerging #9824 will not alter performanceComparing Summary
|
edison1105
approved these changes
Dec 14, 2023
baiwusanyu-c
approved these changes
Dec 14, 2023
yyx990803
requested changes
Dec 15, 2023
| // #9821 | ||
| let cssVarText = (style as any)[CSS_VAR_TEXT] | ||
| if (cssVarText) { | ||
| cssVarText = (next.endsWith(';') ? '' : '; ') + cssVarText |
There was a problem hiding this comment.
All mainstream browsers are able to handle extra ; between properties in inline style, so we can just do ;(next as string) += ';' + cssVarText and make cssVarText a const.
There was a problem hiding this comment.
I have already made the modifications, thank you for your guidance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #9821
During the
patchStyleprocess, if a string type is passed, it will overwrite the entirecssText, leading to the loss of theuseCssVarsvariable. InuseCssVars, I store CSS variables in a private property of the style, which is then collectively set tocssTextduring thepatchStyleprocess.I attempted to use a
MutationObserverto monitor style changes in all child elements. However, in the scenario where we also need to listen to thechildListof theparentNode, I had to add anotherMutationObserverwithin theparentNode's observer to simultaneously monitor newly added child elements. This approach introduces complexity to the logic, so I opted for the current solution.