fix(runtime-dom): cache event handlers by key/modifiers (fix #9849) #9851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When an event handler is used multiple times in a template, for events with different key modifiers, the first wrapped handler that gets created first is being cached and re-used as the handler for all further uses, which breaks the other listeners.
Solution
Cache the created wrapped handler functions in a map object keyed by the specific modifier(s) they were created for
fix #9849
Alternative PR: #9850. That PR's author opted to remove the caching altogether which I think is not what we want. Also the problem needs to be fixed for both
withKeys()
andwithModifiers()
, which my PR does.