fix(reactivity): ensure array extension methods execute correctly #11761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
|
commit: @vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
|
edison1105
reviewed
Aug 31, 2024
| if ( | ||
| targetIsArray && | ||
| // @ts-expect-error our code is limited to es2016 but user code is not | ||
| (target as any[])[key] === Array.prototype[key] && |
There was a problem hiding this comment.
This means that extended methods lose tracking optimization
There was a problem hiding this comment.
I'm sorry, but I don't know what "tracking optimization" means. Is it referring to this part?
There was a problem hiding this comment.
If that's the case, the extended methods indeed lose tracking optimization.
However, I'm puzzled by the mismatch between the variable values and the function's parameter definition during debugging. Although the problem was solved by using arguments.
edison1105
added
scope: reactivity
ready for review
|
We do want to apply the same instrumentations on extended arrays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11759
this pr -- playground
I reverted these two PRs. I think it's more reasonable to judge whether a method is an extended array method when accessing array methods
[#11574] [#11629 ]