Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scheduler): increase recursion limit number #11815

Closed
wants to merge 1 commit into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Sep 5, 2024

close #11807
close #11712
feedback from discussion

After the reactivity system is refactored, it can easily reach the 100 maximum limit per batch.

Copy link

github-actions bot commented Sep 5, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 33.9 kB
vue.global.prod.js 159 kB 57.6 kB 51.2 kB

Usages

Name Size Gzip Brotli
createApp 55.2 kB 21.2 kB 19.4 kB
createSSRApp 59.1 kB 22.9 kB 20.9 kB
defineCustomElement 59.9 kB 22.8 kB 20.7 kB
overall 68.9 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11815

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11815

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11815

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11815

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11815

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11815

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11815

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11815

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11815

vue

pnpm add https://pkg.pr.new/vue@11815

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11815

commit: d4e0666

@edison1105 edison1105 added ready to merge The PR is ready to be merged. ready for review This PR requires more reviews easy to merge labels Sep 5, 2024
@heggria
Copy link
Contributor

heggria commented Sep 5, 2024

This change doesn't seem to fully address the issue. While debugging locally using pnpm link, I found that even when the RECURSION_LIMIT is set to 1000, the problem still occurs if the array is updated more than 1000 times.

@edison1105
Copy link
Member Author

@heggria I know, this PR only addresses more common scenarios.

@skirtles-code
Copy link
Contributor

I've attempted to fix the underlying problem in #11826.

@edison1105 edison1105 closed this Sep 5, 2024
@edison1105 edison1105 deleted the edison/fix/11807 branch September 5, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy to merge ready for review This PR requires more reviews ready to merge The PR is ready to be merged.
Projects
None yet
3 participants