fix(custom-elements): Add children component styles fix #4662 #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted components. Missing feature, store available styles to avoid dupes. close vuejs#4662
…ted components. Missing feature, store available styles to avoid dupes. close vuejs#4662
…ted components. Missing feature, store available styles to avoid dupes. close vuejs#4662
raffobaffo
changed the title
raffobaffo
changed the title
|
Any update on this MR or on the feature in general? |
|
This PR unfortunately isn't the right fix. The original issue is Vue custom elements importing normal Vue components. The latter will not have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this PR is to fix the problematic of customElements not having injected styles of children components. A working example to reproduce the problem is available here ;