fix(suspense): don't run post flush callbacks in suspended component (fix #6811) #7009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #6811 |
|
So apparently this completely breaks post-flsuh watchers in Suspense. I'll add more tests and try to do a proper fix. |
|
@adamjedlicka Is it still your intention to continue working on this PR? If I've understood your previous comment, it sounds like this isn't currently a valid fix. If you don't have time to work on it then should it maybe be closed? |
|
Closing as stale for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #6811 post flush watchers are executed in suspended components that are currently being switched out. This has huge implications for example in routing, where switching pages executes both post flush watchers both on the new page and also on the old page. This PR fixes this issue and causes post flush watchers to be executed ONLY on the new component.
Closes #6811