Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish some Volar types in a standalone package #2557

Closed
rchl opened this issue Mar 29, 2023 · 2 comments
Closed

Publish some Volar types in a standalone package #2557

rchl opened this issue Mar 29, 2023 · 2 comments

Comments

@rchl
Copy link
Collaborator

rchl commented Mar 29, 2023

In #2267 there is an example of a plugin/module that one can create for Volar. It's annotated with a import('@volar/language-core').LanguageModule type but to take advantage of that annotation one would have to have volar installed in the project which IMO is not realistic thing to expect.

My thinking is that the the types (at least LanguageModule and related once) could be published separately so that one could add just the type package as a devDependency to the project.

I can't think of any other solution for that.

@johnsoncodehk
Copy link
Member

"@volar/language-core" is almost a root dependency, and I think is fine to install it in "devDependency". It would be a maintenance issue if separate into an individual type package.

@rchl
Copy link
Collaborator Author

rchl commented Mar 29, 2023

OK

@rchl rchl closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants