Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstanceType doesn't work for components with generic #3593

Closed
avinean opened this issue Sep 26, 2023 · 5 comments
Closed

InstanceType doesn't work for components with generic #3593

avinean opened this issue Sep 26, 2023 · 5 comments
Labels
duplicate This issue or pull request already exists

Comments

@avinean
Copy link

avinean commented Sep 26, 2023

There are 2 components.
One with generic and another one without generic.

Some parent component tries to take an instance type.
The one with generic throws an error
image

Reproduction
https://play.vuejs.org/#eNqdUk1P4zAQ/SsjX7oroaKKWzZUYlc9sAdAkBvmYCWTYEjGlu2URlX/O2MnLR/iQ+ISxfPeG7/xvK04s3a+7lFkIvel0zaAx9BbaBU1p1IEL8VSku6scQG24LCGHdTOdDBj2ezPAftnOjsB8+N4iG1nb+DFG3wxESSVhnwAzR9FJcJpvCU/n47FYDEP/DF1arJc/vr9XrL4RrMYRZLy43FIHkkc8XDcptbN/MEb4hfYSgKQomSFbtFd2qD5GikySEjEVNuap/+pFlyPR/t6eY/l4wf1B7+JNSmuHHp0a5TigAXlGgwjvLq5wA3/H8DOVH3L7C/Aa/Sm7aPHkfa3p4ptv+Ilt+dpAZqawq82Acnvh4pGI3OX+FLwOuJjfTb6i92T+UnSSdrxK+53/VWEoEFCp0s+FilQFdaa8MoZ6/PpBhVPGRTcNW1rpKw6HV4o3WqNFDK4tWpojaoyuEZVGWqHvFje7ZWHLU/uUtK+SXhMC5zF4HCWXjtCF4YMFA3cPUboc+dJ/UP3SfvRBLtnZ2c66w==
@so1ve
Copy link
Member

so1ve commented Sep 26, 2023

Duplicate of #3206

@so1ve so1ve marked this as a duplicate of #3206 Sep 26, 2023
@so1ve so1ve closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2023
@so1ve
Copy link
Member

so1ve commented Sep 26, 2023

Solution: You should use ComponentExposed from the vue-component-type-helpers packages instead of TypeScript's built-in ReturnType or InstanceType utilities since volar defines generic components as functional components.

@so1ve so1ve added the duplicate This issue or pull request already exists label Sep 26, 2023
@avinean
Copy link
Author

avinean commented Sep 26, 2023

@so1ve
This worths to be mentioned in docs

@cernymatej
Copy link

@so1ve Why not include the ComponentExposed type in vue? Since it already has some utility types, I don' think it would be a bad idea... https://vuejs.org/api/utility-types

@so1ve
Copy link
Member

so1ve commented Dec 1, 2023

@cernymatej vuejs/core#5408 vuejs/core#9556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@avinean @so1ve @cernymatej