Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(language-core): typed directive arg and modifiers #4813

Merged
merged 13 commits into from
Oct 23, 2024
Merged

feat(language-core): typed directive arg and modifiers #4813

merged 13 commits into from
Oct 23, 2024

Conversation

KazariEX
Copy link
Collaborator

@KazariEX KazariEX commented Sep 5, 2024 •
edited
Loading

resolve #4810

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 5, 2024 •
edited
Loading

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4813

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4813

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4813

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4813

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4813

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4813

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4813

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4813

commit: 08b446b

@KazariEX KazariEX changed the title feat(language-core) feat(language-core): directive arg and modifiers completion Sep 5, 2024
@KazariEX KazariEX changed the title feat(language-core): directive arg and modifiers completion feat(language-core): typed directive arg and modifiers Sep 5, 2024
@KazariEX KazariEX marked this pull request as ready for review September 5, 2024 14:22
@SomaH123
Copy link

Hey there! Is there any chance that this can be merged in the near future? :)

@KazariEX
Copy link
Collaborator Author

KazariEX commented Sep 25, 2024 •
edited
Loading

Believe that once @johnsoncodehk's work on ViteConf comes to an end, we will be able to quickly merge it!

@johnsoncodehk johnsoncodehk merged commit 1e04fc9 into vuejs:master Oct 23, 2024
5 checks passed
@KazariEX KazariEX deleted the feat/directives-completion branch October 23, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsoncodehk johnsoncodehk Awaiting requested review from johnsoncodehk johnsoncodehk is a code owner

@so1ve so1ve Awaiting requested review from so1ve so1ve is a code owner

@zhiyuanzmj zhiyuanzmj Awaiting requested review from zhiyuanzmj zhiyuanzmj is a code owner

@KermanX KermanX Awaiting requested review from KermanX KermanX is a code owner

@davidmatter davidmatter Awaiting requested review from davidmatter davidmatter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue 3.5, Directive has Modifiers and Arg, editor autocomplete list not use it
3 participants
@KazariEX @SomaH123 @johnsoncodehk