Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

[plugin-next] Fix Rollup when no template in an SFC #387

Merged
merged 6 commits into from
Oct 20, 2020

Conversation

elevatebart
Copy link
Contributor

Changes proposed in this pull request:
SFCs can have a script block only
In this case, the render function should not be replaced by the empty template function.
It should be left alone.

/ping @znck @jtommy

@jtommy
Copy link

jtommy commented Sep 9, 2020

@elevatebart Yes, removing it seems to work as I tried manually but I don't know if it's really correct or not in the new Vue 3 (maybe we are missing something..)

src/index.ts Outdated
isServer
)

const templateImport = descriptor.template
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right condition is !descriptor.template

@@ -0,0 +1,10 @@
<script>
import h from 'vue'
Copy link

@jtommy jtommy Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h isnt' the default export, you should use import { h } from 'vue'

@znck znck merged commit 6960203 into vuejs:next Oct 20, 2020
@meteorlxy
Copy link
Member

Some edge cases that may be related to vuejs/core#2463

@zouhangwithsweet
Copy link

I am troubled by this question.
When will you release the new version, maybe beta.11 ?:clap:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants