-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme-default): add built-in global component Badge. #1239
Conversation
…lobal component `Badge`.
Make badge available via enhanceApp instead of globally.
Add trailing new line to VPBadge.vue
Use existing color variables for badges.
looking forward... |
Any updates please? |
I'll look into this! |
@kiaking How is it going? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the styles to match VitePress's custom container, and made few adjustment.
- remove
vertical
since the difference was trivial. We could add it back if we get high demand. - change
error
->danger
to be consistent with custom container.
@brc-dd I've updated the docs! Could you take a final look? If it looks OK, please merge it! 🙌 |
It's suprising that those changes could be merged. I thought this feature wouldn't be accepted due to the consideration here, so I stopped watching the #1134, I feel very sorry. Anyway, thx for @szsascha @kiaking ! ♪(・ω・)ノ it's nice of you to take another PR and make it better. |
Doesnt look to be rendered in my test env |
@Goozoon Can you share a minimal reproducible example? It is working fine on our deployed docs. You might not have extended the default theme properly. |
Pure vanilla Yarn Init thingy and copy=paste from the docs to see the result. Nothing about "extended the default theme" in the docs.
|
@Goozoon It's working fine for me: https://stackblitz.com/edit/vite-wbmmgk?file=docs%2Findex.md If it's not for you, feel free to open a new issue with details. Also, can you check if you're on the latest VitePress version? |
let me check yours.. thank you |
my fault: yarn docs:dev -> vitepress v1.0.0-draft.8 in dependencies: "devDependencies": { |
fixes open changes from #1134 since there is no progress anymore and some people really want this feature
close #1134
close #1156