Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix initial url path for non ascii urls #2375

Merged
merged 2 commits into from
Sep 4, 2018

Conversation

aldarund
Copy link
Contributor

@aldarund aldarund commented Sep 4, 2018

Here is demo of issue https://codesandbox.io/s/m2xnyj5zx

If click links withing app - active class applies fine for both links
If load page on /hello - active class applies to hello link fine
If load page on /тест - active class applies not applied to /тест link and the component not loaded

The problem is because on initial load vue-router use window.location.pathname for path, which is uri encoded, so it wont match routes because they are not uri encoded.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will add a test locally and make some changes to hashmode as well to make it work

@AbdallahSabri
Copy link

Does anyone solve this issue?

@aldarund
Copy link
Contributor Author

@AbdallahSabri what u mean?

@AbdallahSabri
Copy link

@aldarund I mean does anyone fix initial url path for non ascii urls?

@aldarund
Copy link
Contributor Author

@AbdallahSabri as you can see this PR was merged. So its fixed. But it wasnt released to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants