-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TS): update type of Route.name #3117
Conversation
On very first load, `name` is `null`, not `string` or `undefined`. This means that either the passed route is wrong, or the type is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, only the initial location has a name of null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot, can you fix the failing test?
Jumped into it too hastily before.. it's fixed now @posva 🙂 |
Thanks! |
Appearantly so. Please open a new issue about this. |
@zhuwenqi001 see #3139 |
On very first load,
name
isnull
, notstring
orundefined
. This means that either the passed route is wrong, or the type is incorrect.