fix(ssr): should render 0 as valid value for style property with unit

vuejs · Jan 12, 2019 · aef5b4e · aef5b4e
1 parent 584e89d
commit aef5b4e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/platforms/web/server/modules/style.js b/src/platforms/web/server/modules/style.js
@@ -23,7 +23,8 @@ export function genStyle (style: Object): string {
 function normalizeValue(key: string, value: any): string {
   if (
     typeof value === 'string' ||
-    (typeof value === 'number' && noUnitNumericStyleProps[key])
+    (typeof value === 'number' && noUnitNumericStyleProps[key]) ||
+    value === 0
   ) {
     return `${key}:${value};`
   } else {

diff --git a/test/ssr/ssr-string.spec.js b/test/ssr/ssr-string.spec.js
@@ -1529,13 +1529,14 @@ describe('SSR: renderToString', () => {
       data: {
         style: {
           opacity: 0, // valid, opacity is unit-less
-          top: 0, // invalid, top requires unit
+          top: 0, // valid, top requires unit but 0 is allowed
+          left: 10, // invalid, left requires a unit
           marginTop: '10px' // valid
         }
       }
     }, result => {
       expect(result).toContain(
-        '<div data-server-rendered="true" style="opacity:0;margin-top:10px;"></div>'
+        '<div data-server-rendered="true" style="opacity:0;top:0;margin-top:10px;"></div>'
       )
       done()
     })