Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hooks): add renderTracked/Triggered merge strategy #12616

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

chearon
Copy link
Contributor

@chearon chearon commented Jul 5, 2022

Hi, the renderTracked and renderTriggered hooks almost work (Options API) but it looks like a merge strategy was never added. callHook expects $options[hook] to be an array

Here is a demo: https://jsfiddle.net/qvmz2dps/

Thought it was straightforward enough not to add tests, but I can do so

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

`callHook` expects $options[hook] to be an array
@yyx990803 yyx990803 merged commit 6d1dbee into vuejs:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants