Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON.stringify in looseEqual does not have necessary keys in the same order #5908

Closed
mitar opened this issue Jun 17, 2017 · 0 comments
Closed

JSON.stringify in looseEqual does not have necessary keys in the same order #5908

mitar opened this issue Jun 17, 2017 · 0 comments
Labels
improvement

Comments

@mitar
Copy link
Contributor

mitar commented Jun 17, 2017

I see that in looseEqual function you are using JSON.stringify, but JSON.stringify has no quarantines on key order when serializing. See here:

Properties of non-array objects are not guaranteed to be stringified in any particular order. Do not rely on ordering of properties within the same object within the stringification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yyx990803 @mitar