Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #5941, should check $vnode existence before accessing ssrContext #5981

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

jkzing
Copy link
Member

@jkzing jkzing commented Jun 26, 2017

#5941

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@jkzing jkzing force-pushed the fix-ssr-context branch from 85529d2 to 6d69f9f Compare June 26, 2017 18:50
should not create $ssrContext for root component, because it doesn't has $vnode

vuejs#5941
@jkzing jkzing force-pushed the fix-ssr-context branch from 6d69f9f to 96d337a Compare June 27, 2017 02:56
@jkzing jkzing changed the title fix #5941, should not create $ssrContext for root component fix #5941, should check $vnode existence before accessing ssrContext Jun 27, 2017
@yyx990803 yyx990803 merged commit 5581654 into vuejs:dev Jun 29, 2017
@jkzing jkzing deleted the fix-ssr-context branch June 29, 2017 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants