perf: optimize the performance of hyphenate method. #6274
Conversation
* build(release weex): ignore the file path of entries * [release] weex-vue-framework@2.4.2-weex.1
Modify the regular to make the `replace` method call only once to optimize performance.
package.json
Outdated
| @@ -129,4 +129,4 @@ | |||
| "path": "./node_modules/cz-conventional-changelog" | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
@posva Sorry about that, I have already undo this change :)
|
Didn't even know about |
Modify the regular to make the `replace` method call only once to optimize performance.
|
Doing some perf checks and it looks like the old version is faster though 😆 |
|
@posva |
|
Technically this is a breaking change. What counts as a word is listed in http://www.ecma-international.org/ecma-262/5.1/#sec-15.10.2.6. While an identifier can contain
But using dollar sign is not recommended in Vue. I think this change should be good. |
|
@HerringtonDarkholme But I'm not sure if the parameter should contain |
Modify the regular to make the
replacemethod call only once to optimizeperformance.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This is a performance test: https://jsperf.com/vue-hyphenate