Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($core): call data method with this (#6739) #6760

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Conversation

Kingwl
Copy link
Member

@Kingwl Kingwl commented Oct 9, 2017

#6739

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@javoski
Copy link
Member

javoski commented Oct 9, 2017

The test case might be better to be placed in https://github.com/vuejs/vue/blob/dev/test/unit/features/options/data.spec.js

@Kingwl Kingwl changed the title feat($core): call data method with this (fix 6739) feat($core): call data method with this (#6739) Oct 10, 2017
@yyx990803 yyx990803 merged commit 3a5432a into vuejs:dev Oct 10, 2017
ztlevi pushed a commit to ztlevi/vue that referenced this pull request Feb 14, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants