Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): correctly set activeindex of select element in a new v-model #6910

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

gebilaoxiong
Copy link
Member

#6903

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@gebilaoxiong gebilaoxiong changed the title fix($browser): correctly set select activeIndex in v-model fix(model): correctly set activeindex of select element in a new v-model Oct 26, 2017
@@ -546,4 +546,30 @@ describe('Directive v-model select', () => {
expect(spy).not.toHaveBeenCalled()
}).then(done)
})

// #6903
it('should set the selectedIndex correctly in the new v-mode', done => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling: v-mode :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 😄

@gebilaoxiong gebilaoxiong force-pushed the fix-select-active-index branch 2 times, most recently from a8e28ac to fa56f64 Compare November 1, 2017 07:26
@yyx990803 yyx990803 merged commit 58a39df into vuejs:dev Nov 3, 2017
@gebilaoxiong gebilaoxiong deleted the fix-select-active-index branch November 3, 2017 02:05
yyx990803 added a commit that referenced this pull request Nov 3, 2017
lovelope pushed a commit to lovelope/vue that referenced this pull request Feb 1, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants