Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR - mismatched styles are not updated in the DOM unless the element has a ref #7063

Closed
KaelWD opened this issue Nov 15, 2017 · 1 comment
Closed
Labels

Comments

@KaelWD
Copy link
Contributor

KaelWD commented Nov 15, 2017

Version

2.5.3

Reproduction link

https://codepen.io/anon/pen/GOvGBJ?editors=1010

Steps to reproduce

Load the codepen.
This is obviously not an actual SSR app, but is emulating one. The same thing happens with actual SSR that sets the padding based on window width.

What is expected?

The inline style should be updated when the page hydrates (see the codepen below)

What is actually happening?

The style only updates if the element has a ref
See https://codepen.io/anon/pen/aVyjoM?editors=1010

KaelWD added a commit to vuetifyjs/vuetify that referenced this issue Nov 15, 2017
 - Prevents the initial animation on non-ssr pages
 - Uses a ref hack to set the correct styles on content elements - see
   vuejs/vue#7063
johnleider added a commit to vuetifyjs/vuetify that referenced this issue Nov 15, 2017
…ent (#2495)

* fix(v-navigation-drawer): update drawer states reactivity with permanent

fixes #2493

* Create failing test cases

* simplfied logic, fixed tests, added one

* remove overlay when being resized from mobile to desktop and active

* run tryOverlay when temporary toggles

* test: use expect().toBeTruthy()

* Remove booting from drawer

 - Prevents the initial animation on non-ssr pages
 - Uses a ref hack to set the correct styles on content elements - see
   vuejs/vue#7063
@yyx990803 yyx990803 added the bug label Nov 16, 2017
lovelope pushed a commit to lovelope/vue that referenced this issue Feb 1, 2018
@KaelWD
Copy link
Contributor Author

KaelWD commented Mar 9, 2018

This doesn't seem to have been fixed for classes?

No ref: https://codepen.io/anon/pen/yKyBYZ
With ref: https://codepen.io/anon/pen/PRwYPO

Should I open a new issue or is this expected behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants