-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): contravariant generic default in ComponentOption #7369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsn
reviewed
Jan 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also change AsyncComponent
default generic type?
HerringtonDarkholme
force-pushed
the
types
branch
from
January 3, 2018 05:43
7c16e44
to
fc13423
Compare
Updated! |
ktsn
approved these changes
Jan 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
lovelope
pushed a commit
to lovelope/vue
that referenced
this pull request
Feb 1, 2018
This was referenced Mar 14, 2018
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
Fix bugs spotted in vuejs/vue-test-utils#317 (comment).
Some type theory shenanigans below:
This pull request allows assigning
ComponentOption
of a Vue subclass toComponent
. The problem is that we used to mark default vm type asVue
inComponent
. However, sinceComponentOption
is contravariant against vm typeV
. The default bound should not be the upper boundVue
, but the lower boundnever
.For a more concrete example, consider this usage:
Then, assigning option to
ComponentOption<Vue>
, we could in theory do unsafe operation:Though it is not how we really use Vue, type checker cannot know this. To workaround, we can mark
anotherOption
to have vm type asnever
.never
is the bottom type of any type, soComponentOption<never>
'screate
method can accept nothing, and thusly anycreate
method from subclass can satisfy accepting nothing semantic. In practical words, this means we promise that we never usecreated
like the way above.