Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): support chain call #8595

Merged
merged 15 commits into from
Dec 1, 2018
Merged

fix(types): support chain call #8595

merged 15 commits into from
Dec 1, 2018

Conversation

lzxb
Copy link
Contributor

@lzxb lzxb commented Aug 3, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

image

@lzxb lzxb changed the title Fix types, Support chain call fix(types) Support chain call Aug 3, 2018
@lzxb lzxb changed the title fix(types) Support chain call fix(types): Support chain call Aug 3, 2018
@lzxb lzxb changed the title fix(types): Support chain call fix(types): support chain call Aug 3, 2018
@lzxb lzxb closed this Aug 3, 2018
@lzxb lzxb reopened this Aug 3, 2018
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test case for types?

@ktsn
Copy link
Member

ktsn commented Aug 3, 2018

What do you mean? I actually did request you to add some test case in here to confirm that this type annotation is correct.

@lzxb
Copy link
Contributor Author

lzxb commented Aug 3, 2018

Yes, I can add.

.use(() => {

})
.mixin({});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only checks return type of use. We also need to check return type of mixin.


// #8595
it('chain call', () => {
expect(Vue.mixin({}).toBe(Vue))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo.

expect(Vue.mixin({})).toBe(Vue)

@lzxb
Copy link
Contributor Author

lzxb commented Aug 4, 2018

All test add done.

Copy link

@chillcaw chillcaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes and the added test look solid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants