We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.5.18-beta.0
https://github.com/vuejs/vue/blob/v2.5.18-beta.0/src/server/template-renderer/index.js
No need to repro, it's written in the code.
vue/src/server/template-renderer/index.js
Line 233 in e8031b4
here it's used path.posix.join ( #8177 ), thus if publicPath begin with https:// or http://, one of the double slashes disapper, become https:/.
path.posix.join
https://
http://
https:/
publicPath = ''https://cdn.nuxtjs.org/" generates "https://cdn.nuxtjs.org/xxx.js"
publicPath = ''https://cdn.nuxtjs.org/" generates "https:/cdn.nuxtjs.org/xxx.js"
The text was updated successfully, but these errors were encountered:
078f9c7
fix(ssr): fix ssr template publicPath generation
f077ed1
fix #9145
0076e21
fix vuejs#9145
ce7ce33
No branches or pull requests
Version
2.5.18-beta.0
Reproduction link
https://github.com/vuejs/vue/blob/v2.5.18-beta.0/src/server/template-renderer/index.js
Steps to reproduce
No need to repro, it's written in the code.
vue/src/server/template-renderer/index.js
Line 233 in e8031b4
here it's used
path.posix.join
( #8177 ), thus if publicPath begin withhttps://
orhttp://
, one of the double slashes disapper, becomehttps:/
.What is expected?
publicPath = ''https://cdn.nuxtjs.org/" generates "https://cdn.nuxtjs.org/xxx.js"
What is actually happening?
publicPath = ''https://cdn.nuxtjs.org/" generates "https:/cdn.nuxtjs.org/xxx.js"
The text was updated successfully, but these errors were encountered: