Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning in data merge strategy #5388

Closed
wants to merge 1 commit into from
Closed

Conversation

posva
Copy link
Member

@posva posva commented Apr 6, 2017

This allows to reuse the data merge strategy without forcing it to be
a function when used in a child

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This allows to reuse the data merge strategy without forcing it to be
a function when used in a child
@posva posva force-pushed the fix-data-warning branch from ac2d74e to d9cde49 Compare April 6, 2017 12:30
@yyx990803
Copy link
Member

I don't think this would be sufficient. The code below this condition check assumes childVal is a function.

@posva
Copy link
Member Author

posva commented Apr 11, 2017

That's true. I'll have a deeper look whenever I can.

@yyx990803
Copy link
Member

Seems to be covered in #6025

@yyx990803 yyx990803 closed this Jul 7, 2017
@posva posva deleted the fix-data-warning branch July 7, 2017 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants