Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($core): style and platte path sep on windows (fix #1170) #1246

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

meteorlxy
Copy link
Member

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

Other information:

Related to #1170 and #1164 .

#1164 partly fixed this bug for user override, but not for theme override and parent theme override. This PR is to completely fix that.

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would it be better to create a common util called winPath?

@meteorlxy
Copy link
Member Author

I'm not sure if this is so common.

Currently, only stylus files have the problem. I wonder if this is a bug of stylus-loader.

@ulivz
Copy link
Member

ulivz commented Jan 29, 2019

OK, let's merge it first.

@ulivz ulivz merged commit 592918a into vuejs:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants