Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show current page title in front of site title #522

Merged
merged 1 commit into from
May 29, 2018
Merged

show current page title in front of site title #522

merged 1 commit into from
May 29, 2018

Conversation

gnijuohz
Copy link
Contributor

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

It seems more common (and better IMO) to put current page title before the site title. Some examples:

@ulivz
Copy link
Member

ulivz commented May 29, 2018

Thanks, @yyx990803 do you have any idea for that?

I just found there are two conventions:

image

@yyx990803
Copy link
Member

Yeah, not that I think about it, current title coming first makes more sense.

@ulivz
Copy link
Member

ulivz commented May 29, 2018

@yyx990803 Thanks~

@ulivz ulivz merged commit ffe12b9 into vuejs:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants