Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date): allow configure i18n when using custom adapter #265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmnoori
Copy link

@mmnoori mmnoori commented Aug 19, 2024

If you want to use a custom date adapter, you can configure it using vuetifyOptions.date.adapter = 'custom'

If you want to use a custom date adapter, you can configure it using vuetifyOptions.date.adapter = 'custom'
@userquin
Copy link
Member

If you've a custom adapter the plugin cannot do the work for you, the user should add the corresponding logic: changes in this PR does nothing since the configuration is empty (check the virtual date module here https://github.com/vuetifyjs/nuxt-module/blob/main/src/vite/vuetify-date-configuration-plugin.ts#L34-L38 and the empty code here https://github.com/vuetifyjs/nuxt-module/blob/main/src/vite/vuetify-date-configuration-plugin.ts#L45)

@userquin
Copy link
Member

uhmm, looks like the problem is about i18n, right?

@userquin userquin changed the title Update date.ts fix(date): allow configure i18n when using custom adapter Aug 19, 2024
if (adapter === 'custom' || !enabled)
return
// if (adapter === 'custom' || !enabled)
// return

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be

if (!enabled)
    return

?

Copy link
Author

@mmnoori mmnoori Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using i18n.
i just know when vuetifyOptions.date.adapter is NOT set to 'custom',
configureDate plugin won't change date localization.
I assume your code is right 👍👍👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmnoori can you explain the problem? changing the code with my previous suggestion will fix the problem you're trying to solve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants