Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling logrus #83

Open
klingtnet opened this issue Jul 6, 2017 · 3 comments
Open

Allow disabling logrus #83

klingtnet opened this issue Jul 6, 2017 · 3 comments

Comments

@klingtnet
Copy link
Contributor

First up, thanks for writing oxy! It's neat and helped us quite a bit so far.

However, we need the ability to disable logging from oxy, because we want to decide what to log ourselves.

To that end, we have a tiny fork that has a new github.com/vulcand/oxy/log package, which exposes only the parts of logrus' API that oxy uses, and delegates it to a package-internal *logrus.Logger. All imports of logrus have been changed to import the new package. In addition, it's now possible to .Disable() the logger, which sets the output to io.Discard.

Would you be interested in merging these changes? If not, would you be interested in merging changes that allow swapping out the logger?

And to the wider community: Do you also need to disable (or even change) the logger that oxy uses? If so, say so by :+1_tone3:ing this issue.

@AlexDunmow
Copy link

Not being able to disable or reroute logging is really annoying.

@klizhentas
Copy link
Contributor

Would you be interested in merging these changes? If not, would you be interested in merging changes that allow swapping out the logger?

yes, go for it

@klizhentas
Copy link
Contributor

First up, thanks for writing oxy! It's neat and helped us quite a bit so far.

Glad it was helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants