Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect internal "parsed" state in ServiceWorkerState enum #1162

Open
wanderview opened this issue Jun 13, 2017 · 3 comments
Open

reflect internal "parsed" state in ServiceWorkerState enum #1162

wanderview opened this issue Jun 13, 2017 · 3 comments

Comments

@wanderview
Copy link
Member

Currently the spec defines an internal ServiceWorker state parsed:

https://w3c.github.io/ServiceWorker/#dfn-state

The webidl ServiceWorkerState enum, however, does not define a matching value. The spec does not say what to do if the .state getter is somehow called while the state is parsed.

We could explicitly throw, but I think it would be better to just reflect the state in the enum.

@wanderview
Copy link
Member Author

FWIW I'm landing this change in gecko's webidl for now. I need some value internally for the state during initial script evaluation before installation actually starts. Currently its not accessible to script but of course that could change with stuff like #1077. If anyone would like to use a different name, e.g. evaluating, please let me know.

@jakearchibald
Copy link
Contributor

Given it isn't exposed to script right now, is there anything stopping us changing the name if we did decide to expose it?

@wanderview
Copy link
Member Author

Right, we can change the name if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants