Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we restore the registration record removing step in Clear Registration? #1433

Open
jungkees opened this issue Jun 13, 2019 · 1 comment
Assignees

Comments

@jungkees
Copy link
Collaborator

In #614 (comment), @asakusuma pointed:

should Clear Registration call Remove scope to registration map as well? unregister() is not the only entry point into Clear Registration.

I missed that while reviewing #1415. I think we should restore the registration record removing step in Clear Registration algorithm.

Perhaps we can even use the uninstalling flag as we used to while keeping "killing the resurrection" part in Register algorithm as @jakearchibald did in the PR? I.e., for the unregistered record, subsequent navigations won't match it based on the flag, and subsequent Register will just replace the record.

@jakearchibald jakearchibald self-assigned this Jun 13, 2019
@jakearchibald
Copy link
Contributor

Thanks for catching this. PR: #1434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants