-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explanation to determine a description is meaningless #77
Comments
@JAWS-test, I think section 4.3 should be renamed to Primary Text Computation, or Primary Text Computation for a Subtree, and then be referred by 4.1 Accessible Name Computation and 4.2 Accessible Description Computation. It's too confusing that it's name (Accessible Name and Description Computation) sounds like the others. Also, it should not need to refer to aria-description. It's a recursive algorithm, that can look at all of the nodes in a subtree, but aria-description does not need to be checked on each node. Rather, aria-description needs to be checked in 4.2 if and only if using aria-describedby yields nothing. |
For reference, here's what Chrome's impl does for the description computation. I haven't recently checked it against CORE-AAM etc.:
|
@JAWS-test , I'm working on a draft that basically does what we're talking about, I think it's a step in the right direction but doesn't solve everything. IMO it's much more readable. Feel free to take a look. |
@aleventhal, many thanks for the comprehensive revision. I think it removes all the ambiguities and errors that were previously contained. In the preview, there is only one problem with the numbering of the list items: instead of letters, numbers are used, so that the references (e.g. "2F.i") no longer work. But maybe this is just a CSS problem of the preview. |
Thanks @JAWS-test ! I expect that's an issue with the preview. We'll have to ask Michael Cooper before we land. Also, do you mind adding your comments to the pull request? How did you like the table approach? |
I believe this was resolved by #69 (just not automatically closed). |
The Name computation is clear:
The Description computation is strange:
I think the simplest solution to the problem would be my proposal in #75 (comment).
Another possibility would be:
The text was updated successfully, but these errors were encountered: