Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid combobox example is not a good use for grid #1281

Open
zcorpan opened this issue Dec 4, 2019 · 1 comment
Open

Grid combobox example is not a good use for grid #1281

zcorpan opened this issue Dec 4, 2019 · 1 comment
Labels
Example Page Related to a page containing an example implementation of a pattern

Comments

@zcorpan
Copy link
Member

zcorpan commented Dec 4, 2019

Related: #1255

The Grid Combobox example has a dropdown with a grid where you can navigate between cells. But selecting any of the two cells for one row results in the same action: the value of the first cell is chosen. Therefore, I think the ability to navigate between cells only serves to confuse users, and the dropdown should really be a listbox.

However, it would still be useful to have an example that uses grid where that is more appropriate.

The first thing I thought about was a date picker. However, that is a separate widget altogether.

Another idea is a seat picker, when booking a bus ticket, train ticket, or plane ticket. It could be possible to type the seat you want (e.g. 15c), but also a popup can show all possible seats and allow you to navigate between them and select one.

There are a few considerations with such an example:

  • Maybe a seat picker shouldn't be a popup of a combobox, but its own widget?
  • Seats that are unavailable should not be selectable, but should it be possible to focus them?
  • Seats usually have more information than just the seat's "identifier", like which price class, if it's an emergency exit row, if it's a window seat or an aisle seat, etc.
@zcorpan zcorpan added the Example Page Related to a page containing an example implementation of a pattern label Dec 4, 2019
@smhigley
Copy link
Contributor

smhigley commented Jan 2, 2020

I agree that the current example isn't very illustrative of data that would benefit from being in a grid, but I think in principle it's a valid use of the pattern. Even if any cell within a row performs the same selection, there are some cases where it is more user-friendly to expose the information in the dropdown as a grid. A better example might be selecting a cloud VM image where each choice has information about size, region, OS, status, etc. It's much easier to browse and understand the choices if they are presented as grid data.

More examples are never bad though, so perhaps a train or plane seat picker might be a good second example for a grid combo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Development

No branches or pull requests

2 participants