Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combobox examples rows "combobox-id" are missing tests #1347

Closed
zcorpan opened this issue Mar 3, 2020 · 2 comments
Closed

combobox examples rows "combobox-id" are missing tests #1347

zcorpan opened this issue Mar 3, 2020 · 2 comments
Labels
regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo

Comments

@zcorpan
Copy link
Member

zcorpan commented Mar 3, 2020

npm run regression-report gives

combobox/combobox-autocomplete-both.html:
    combobox-id
combobox/combobox-autocomplete-list.html:
    combobox-id
combobox/combobox-autocomplete-none.html:
    combobox-id

I think those failures were introduced by #1276.

Originally posted by @zcorpan in #1336 (comment)
@zcorpan zcorpan added the regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo label Mar 3, 2020
@spectranaut
Copy link
Contributor

PR with fix open in: #1424

@zcorpan
Copy link
Member Author

zcorpan commented Oct 27, 2021

PR was merged, closing.

@zcorpan zcorpan closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zcorpan @spectranaut