-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color contrast testing procedure and its documentation for APG examples #1392
Comments
One thing I discovered is that if you use Firefox to test Windows High Contrast Mode, you need to turn on WHCM before opening Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1633911 |
Also, there is a setting regarding link colour which works independently of WHC in Firefox. I thought the "dark blue links against black" bug was fixed, but it's only fixed if you first change the link colour yourself in FF's own settings. I changed mine to yellow, which results at times in yellow text against white pages if I'm switching between WHC and not. Something to be aware of. Edit: I wonder about the listing of IE here, instead of Edge. Or is the assumption that the Chrome tested is a canary which supports WHC? |
That's a good point @StommePoes - just had that thought too. I don't know that we should be listing documentation for IE since we dropped IE support earlier in the year (see #1304). Thoughts? |
I didn't touch the FF settings because I prefer to always test with defaults (otherwise the size of the test matrix just goes exponential 😄). If I close Firefox, turn on WHC Black, and then reopen Firefox, I am able to open any number of tabs that all look ok (i.e. yellow links on black background). So the "dark blue links against black" bug does indeed seem fixed, but only if Firefox has a chance to fully initialize with WHC already on. Thanks for the reminder to test WHC White. I tried it out (without touching the FF color settings) and, as long as I turn on WHC White before opening Firefox, I can open as many Wikipedia tabs as I like, and they all look good, with white background, black text, blue links, and purple visited links (i.e. the default colors for WHC White).
APG did drop support for IE, but we were talking about using IE for WHC testing yesterday, given that we thought FF had WHC inconsistency bugs (which it does, but it can still be used for testing if you switch on WHC first and then open FF). Thank-you for nudging me to test with CrEdge! I knew that pre-chromium Edge supported WHC, but I thought that CrEdge didn't support it yet, given that it's still in canary in Chrome, but I just tried WHC in the latest CrEdge (version 81) and it's already supported! There's a bit of wonkiness in the Wikipedia header, but other pages I tried look correct. Visited links are the same color as unvisited, but that's the same as IE. It's very cool that WHCM will finally be supported in Chrome soon. Looking forward to being able to test in whatever browser I happen to be in. I also discovered this very interesting "coming soon" tidbit in the MS Edge blog:
I guess we should still be testing in pre-chromium Edge just a little while longer... at least until CrEdge shows up in Windows Update for everybody (any day now? I've had it since it was released in January, but for whatever reason, the other 2 Windows machines in our household still have the old Edge. I thought they said April. 🤔).
|
There are two important differences between IE/Firefox and Edge in HCM:
|
It should also be noted that the CSS properties for querying the HCM (forced-colors, prefers-color-scheme, inverted-colors, prefers-contrast, forced-color-adjust, -ms-high-contrast, -ms-high-contrast-adjust) are currently supported very differently: In my opinion, they should therefore not be used at present. |
I use chromiedge and WHC currently and there are several bugs, although all due to devtools... however Chris Heilmann suggested I check the canary for Edge which I did because he said there have been many fixes... and all my devtools bugs had been fixed. The <mark> bug has not been fixed: IE and even canary Edge keep mark text black even if you use a Black theme. Firefox backplates it all with the yellow mark background colour. @JAWS-test yes, Edge uses a "backplate" for text. When Chrome gets standard WHC support, it'll do the same, and FF has showing background images (and thus with a backplate) somewhere on their list of bugs, I just don't know where that is on their schedule. When I'm auditing for WHC, I'll use either IE or FF for testing the no-background-images case, because I feel that's enough browsers to check if important info is lost without those images. If FF, Chrome and Edge all support background images, that'll no longer be on my list. |
@StommePoes @carmacleod @charmarkk @JAWS-test Thank you all for Window High Contrast testing info. I will summarize findings and add those to APG example review document. |
@JAWS-test I appreciate your codepen examples! Your second code pen example demonstrates that ms-high-contrast property works under WHC. By the way, can you kindly add more details to understand what you mentioned below? Thanks for your consideration.
|
At APG meeting, we also talked about "current color" in terms of color constrast testing. @carmacleod By any chance, do you remember the context of the discussion? |
@a11ydoer |
@JAWS-test Thanks for your prompt response. As far as I know, APG Examples do not use ms-high-contrast property at all. We can make note about those but that may be more relevant to code review section. Let me think about it. Btw, my understanding is that Dark mode is one of HCM options, isn't it? |
HCM and Dark Mode are different things. But there is the CSS property prefers-color-scheme that query both:
If a white on black scheme is used in the HCM (white font on black background), a dark mode should be detected automatically, although it is not a dark mode. HCM overwrites all colors. Dark Mode, on the other hand, is a user preference to which a website can react but does not have to. This means that in dark mode the page is only adapted if the author uses appropriate media queries. |
@a11ydoer The currentColor discussion that I mentioned on the call begins at #1132 (comment) and continues for several comments after that. |
@a11ydoer This is a bare minimum for testing WHCM, but I figured it was better to get something written down than not to have any steps at all. Here's what I added:
Please try the steps out with any example, and make sure you agree that the steps accurately describe what to do. |
The APG group would like to have standard procedure to test color contrast, high contrast mode for each APG example. This will be part of APG example review documentation and useful resources to anyone who would like to assist the review ARIA APG example.
The text was updated successfully, but these errors were encountered: